Unit tests for send_statustext_msg function#82
Merged
hannatonthat merged 6 commits intomainfrom Jul 22, 2025
Merged
Conversation
ellyokes253
reviewed
May 5, 2025
Comment on lines
26
to
29
| messages = [ | ||
| "System startup", # Regular message (success) | ||
| "A" * 50, # Exactly 50 characters (success) | ||
| "B" * 51, # 51 characters (fail) |
Contributor
There was a problem hiding this comment.
really minor, but can you make a list of valid messages, and then a separate list of non-valid messages? and test those separately?
ellyokes253
approved these changes
May 14, 2025
Contributor
ellyokes253
left a comment
ellyokes253
left a comment
There was a problem hiding this comment.
mb clicked the wrong review settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.