Communication worker unit tests #252

agslaj-ALock · 2025-02-08T08:36:09Z

Wrote the communications worker unit test
Fixed a typo inside communications

maxlou05

Reviewed

tests/unit/test_communications.py

maxlou05 · 2025-02-09T16:19:37Z

tests/unit/test_communications.py

+            object_in_world_from_position_local(local_position_1),
+            object_in_world_from_position_local(local_position_2),
+        ]
+        number_of_messages = 2


Just use len(objects_in_world)

maxlou05 · 2025-02-09T16:21:04Z

tests/unit/test_communications.py

+        # Conversion
+        result, worker_id, actual_1 = message_encoding_decoding.decode_bytes_to_position_global(
+            generated_objects[0]
+        )
+        assert result
+        assert worker_id is not None
+        assert actual_1 is not None
+
+        result, worker_id, actual_2 = message_encoding_decoding.decode_bytes_to_position_global(
+            generated_objects[1]
+        )
+        assert result
+        assert worker_id is not None
+        assert actual_2 is not None
+
+        # Test
+        assert_global_positions(global_position_1, actual_1)
+        assert_global_positions(global_position_2, actual_2)


You can put this in a loop

maxlou05 · 2025-02-09T16:21:30Z

tests/unit/test_communications.py

+
+        actual = object_in_world_from_position_local(local_position)
+        objects_in_world = [actual]
+        number_of_messages = 1


maxlou05 · 2025-02-09T16:22:23Z

tests/unit/test_communications.py

+        position = object_in_world_from_position_local(local_position)
+
+        objects_in_world = [position, position, position]
+        number_of_messages = 3


maxlou05

Reviewed

maxlou05 · 2025-02-10T01:08:45Z

modules/communications/communications.py

+        objects_in_world = objects_in_world or []
+


My bad, I realized that we will never receive None as an input, the worker takes care of that and makes sure the type coming in is the same as the type listed above. You can probably remove that test case

tests/unit/test_communications.py

maxlou05 · 2025-02-10T01:13:14Z

tests/unit/test_communications.py

+            metadata
+        )
+        assert result
+        assert worker_id is not None


Can you assert this is worker_enum.COMMUNICATIONS_WORKER? (Also from common's data_encoding module)

maxlou05 · 2025-02-10T01:15:17Z

tests/unit/test_communications.py

+                generated_objects[i]
+            )
+            assert result
+            assert worker_id is not None


worker_enum.COMMUNICATIONS_WORKER

maxlou05 · 2025-02-10T01:16:45Z

tests/unit/test_communications.py

+        assert actual_number_of_messages == 0
+        assert len(generated_objects) == 0
+
+    def test_none(self, communications_maker: communications.Communications) -> None:


My bad, no need for this lol

maxlou05 · 2025-02-10T01:24:28Z

tests/unit/test_communications.py

+        assert metadata is not None
+        assert generated_objects is not None


check types

maxlou05 · 2025-02-10T01:24:32Z

tests/unit/test_communications.py

+            metadata
+        )
+        assert result
+        assert worker_id is not None


maxlou05 · 2025-02-10T01:24:37Z

tests/unit/test_communications.py

+        )
+        assert result
+        assert worker_id is not None
+        assert actual_number_of_messages is not None


maxlou05 · 2025-02-10T01:24:56Z

tests/unit/test_communications.py

+            )
+            assert result
+            assert worker_id is not None
+            assert actual is not None


maxlou05 · 2025-02-10T01:25:01Z

tests/unit/test_communications.py

+                generated_object
+            )
+            assert result
+            assert worker_id is not None


maxlou05

Approved!

agslaj-ALock added 3 commits February 6, 2025 15:28

Created test_communications.py

3c054f2

Modified the test to match the PR

e9b7cfa

wrote communications unit test and fix typo in communications

ce65458

maxlou05 reviewed Feb 9, 2025

View reviewed changes

agslaj-ALock added 2 commits February 9, 2025 12:44

Fixed all the comments

5298621

style: auto-format code with linter

be98e98

maxlou05 reviewed Feb 10, 2025

View reviewed changes

fix: resolve issues from code review

77913cc

maxlou05 approved these changes Feb 10, 2025

View reviewed changes

agslaj-ALock merged commit c21a30c into main Feb 10, 2025
1 check passed

agslaj-ALock deleted the Communication-worker-unit-tests branch February 10, 2025 02:54

		assert metadata is not None
		assert generated_objects is not None

Communication worker unit tests #252

Communication worker unit tests #252

Uh oh!

Conversation

agslaj-ALock commented Feb 8, 2025

Uh oh!

maxlou05 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxlou05 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxlou05 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants