Skip to content

Remove reliance on nonexistent UDP binding return code.#213

Merged
bemasc merged 1 commit intodevfrom
bemasc-holoice
Jun 30, 2015
Merged

Remove reliance on nonexistent UDP binding return code.#213
bemasc merged 1 commit intodevfrom
bemasc-holoice

Conversation

@bemasc
Copy link
Contributor

@bemasc bemasc commented Jun 30, 2015

Review on Reviewable

@trevj
Copy link
Contributor

trevj commented Jun 30, 2015

Good find! bind does at least throw an exception if an error occurs? :$

👍

@bemasc
Copy link
Contributor Author

bemasc commented Jun 30, 2015

bind is supposed to reject if there's a problem, yes. This is already true in Chrome, and soon will be in Firefox too: freedomjs/freedom-for-firefox#71

bemasc added a commit that referenced this pull request Jun 30, 2015
@bemasc
Merge pull request #213 from uProxy/bemasc-holoice
3605622 
Remove reliance on nonexistent UDP binding return code.
@bemasc bemasc merged commit 3605622 into dev Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bemasc @trevj