move the NAT diagnosis code from uproxy-probe into this repo#240
Merged
Conversation
Contributor
Author
|
I almost forgot: not sure yet what to do with the server code in uproxy-probe. No reason it couldn't move in here too, at some point. |
src/nat/probe.ts
Outdated
Contributor
There was a problem hiding this comment.
I think the style guide demands ===.
Contributor
Author
There was a problem hiding this comment.
Yep, fixed. As discussed, I've filed an issue to perform a deeper cleanup:
UWNetworksLab/uProxy-p2p#1808
Contributor
|
👍 but maybe we should just have a general issue to do a style cleanup. |
trevj
added a commit
that referenced
this pull request
Aug 7, 2015
move the NAT diagnosis code from uproxy-probe into this repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I needed a break from Docker stuff and finally made a start on this:
UWNetworksLab/uProxy-p2p#1509
Having combed through the code, I just copied the
doNatProvoking()function --doUdpTestanddoStunAccessTestare super-low-level functions we can do with standard tools (pingandstunclientrespectively). I renameddoNatProvoking->probe.Also, a lightweight Chrome and Firefox app called "uprobe" (console output only, I figure we don't use this often enough to justify any much more).
Tested with uProxy itself; pull request to follow.