Skip to content

Conversation

@trevj
Copy link
Contributor

@trevj trevj commented Dec 10, 2015

@lucyhe, could really use your advice here:

  • is inviteUser invoked with the ID of the user to which you're offering access?
  • right now this returns an invite code as it should be distributed amongst users; is that what uProxy expects or should I be returning an object and allowing uProxy base64 encode it (or something)?

Review on Reviewable

@lucyhe
Copy link
Contributor

lucyhe commented Dec 10, 2015

Since the codes aren't related to any contacts in the roster, I dont think inviteUser should expect a userId. Right now we have a function getInviteUrl() that calls inviteUser with an empty string, and returns a www.uproxy.org/invite/... url. I think this is probably what we want to use for cloud (at least for now)!

If possible, it would be best for inviteUser to return an object: { networkData :string }. uProxy will base64 this to turn it into the URL. Lets chat if that doesn't seem to work well with what you have so far; we can figure something else out!

@trevj
Copy link
Contributor Author

trevj commented Dec 11, 2015

OK, as discussed:

  • uProxy will pass a clientId to inviteUser, as per-Github
  • inviteUser now returns an object, with a networkData field that uProxy will base64 encode

@lucyhe
Copy link
Contributor

lucyhe commented Dec 11, 2015

👍


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

trevj added a commit that referenced this pull request Dec 14, 2015
implement inviteUser in the cloud social provider
@trevj trevj merged commit 61b090a into master Dec 14, 2015
@trevj trevj deleted the trevj-inviteUser branch December 14, 2015 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants