Session-aware HPC plot wrappers (#25)#39
Merged
Conversation
plot_mesh_hpc, plot_variable_hpc, and plot_zonal_mean_hpc now accept session_id + dataset_handle and resolve grid/data paths from a registered session dataset via _resolve_plot_paths, matching the handle pattern already used by subset_bbox / subset_polygon. Direct grid_path / data_path arguments still work; the new params are optional and validated by the existing _resolve_plot_paths helper, which raises clear ValueErrors for missing session_id or missing path+handle combinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plot_mesh_hpc,plot_variable_hpc,plot_zonal_mean_hpcnow acceptsession_id+dataset_handleand resolve grid/data paths via_resolve_plot_paths, matching the pattern used bysubset_bbox/subset_polygon.grid_path/data_patharguments still work; the new params are optional. Missing combinations raise clearValueErrors from the existing helper.Test plan
uv run pre-commit run --all-files— cleanuv run pytest tests/ --ignore=tests/test_remote_agent.py -q— 230 passed, 5 skippeduv run pytest tests/test_hpc_safety.py tests/test_remote_agent.py -q— 31 passed, 10 skippedTestHpcPlotWrappersDatasetHandleclass covers handle resolution + the two negative cases (handle without session_id, neither path nor handle)