fix(mllm-cli): correct return value check in isOk function#458
Merged
chenghuaWang merged 1 commit intoUbiquitousLearning:v2from Sep 28, 2025
Merged
fix(mllm-cli): correct return value check in isOk function#458chenghuaWang merged 1 commit intoUbiquitousLearning:v2from
chenghuaWang merged 1 commit intoUbiquitousLearning:v2from
Conversation
The isOk function was incorrectly checking for 0 as success, but the C library returns 1 for success. This change aligns the Go code with the expected C library behavior. fix(task.py): remove redundant error handling in build task The redundant error checking and logging has been removed from the build task as the throw_error_if_failed function already handles error cases appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isOk function was incorrectly checking for 0 as success, but the C library returns 1 for success. This change aligns the Go code with the expected C library behavior.
fix(task.py): remove redundant error handling in build task
The redundant error checking and logging has been removed from the build task as the throw_error_if_failed function already handles error cases appropriately.