Updated extension analyzer to latest support #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sadly not only the use of the `extension` keyword has issues but so do analyzers intended to find such usage.
- For now the only options is a RegEx source level find across the entire solution for `extension(?([^\r\n])\s)*\(` [Match case]
* Updated System.CommandLine to latest build
- Updated tests to account for known issues resolved
- Still has [Bug 2664](dotnet/command-line-api#2664) where it treats `--version` as a value of a preceding property instead of an error that the option isn't used alone.
* Added comments to various extension classes why it is NOT allowed to use the `extension` keyword yet.
- Hopefully this changes soon after launch of .NET 10, we'll see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated extension analyzer to latest support
extensionkeyword has issues but so do analyzers intended to find such usage.extension(?([^\r\n])\s)*\([Match case]--versionas a value of a preceding property instead of an error that the option isn't used alone.extensionkeyword yet.