Multi-Targetting support for targets used in Source Generators/Analyzers and VSIX #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using a Roslyn Source generator has problems with dependencies.
* Added Code analysis utilities
- Targets .NET8 and .NET Standard 2.0
* Doc comment updates/corrections
* Removed exception from `DisposableAction.Dispose`
- `Dispose` should not throw an exception.
* Added support for resource string formatting simlification.
* Replaced `nint.Zero` with `IntPtr.Zero` or `0`
- Originally, the methods exposed by nint were filtered to exclude `Zero` and then later converted to a pure alias. Sadly, the compiler language version does ***NOT*** control this behavior. It's ` System.Runtime.CompilerServices.RuntimeFeature.NumericIntPtr`
* Added multipe define checks based on the target framework to allow projects to multi-target
…rServices.RuntimeHelpers.GetSubArray<T>` method
- Apparently the compiler doesn't take extensions into account and requires existence of the static method directly on the type. So no poly fill is possible.
* Added exception to detect if native API returns an invalid (null or empty)
* Fixed bug in fluent `ThrowIfOutOfRange` handling
* Blocked out `System.Runtime.CompilerServices.RuntimeHelpers.GetSubArray<T>`
* Since the LLVM-C API uses `unwrap<DIExpression>(Expr)` that will `assert` in a debug build that the `Expr` is NOT null. In a release build it sitll does the right thing and treats a null as if it was empty but in a debug build it will assert causing a dialog and potential app crash.
- Most cases used a null coelescence operation to provide a non-null expression but `DiBuilderAlias.CreateGlobalVariableExpression` did not do that.
Test Results 12 files 12 suites 46s ⏱️ Results for commit 36974e4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds suport for more pojects to support multi-targetting.
It is worth considering how to move these "support" libraries to
a distinct repo that is NOT connected to LLVM at all. They are now rich enough on their own to warrant a distinct repo.
Moved poly fills to a shared project.
DisposableAction.DisposeDisposeshould not throw an exception.nint.ZerowithIntPtr.Zeroor0Zeroand then later converted to a pure alias. Sadly, the compiler language version does NOT control this behavior. It'sSystem.Runtime.CompilerServices.RuntimeFeature.NumericIntPtrSystem.Runtime.CompilerServices.RuntimeHelpers.GetSubArray<T>methodThrowIfOutOfRangehandlingSystem.Runtime.CompilerServices.RuntimeHelpers.GetSubArray<T>Fixed handling of DIExpression
unwrap<DIExpression>(Expr)that willassertin a debug build that theExpris NOT null. In a release build it sitll does the right thing and treats a null as if it was empty but in a debug build it will assert causing a dialog and potential app crash.DiBuilderAlias.CreateGlobalVariableExpressiondid not do that.