Skip to content

Fix numpy error, outdated np.object > object#27

Open
ArnovanHilten wants to merge 1 commit into
UcarLab:mainfrom
ArnovanHilten:main
Open

Fix numpy error, outdated np.object > object#27
ArnovanHilten wants to merge 1 commit into
UcarLab:mainfrom
ArnovanHilten:main

Conversation

@ArnovanHilten
Copy link
Copy Markdown

np.object gives problems in newer numpy versions (deprecated)

@ArnovanHilten
Copy link
Copy Markdown
Author

np.object gives problems in newer numpy versions (deprecated)

@chlee-tabin
Copy link
Copy Markdown

+1 — independently hit this on Python 3.11 + NumPy ≥ 1.24 in the snapatac2 conda env while running AMULET on duck (Anas platyrhynchos) multiome data. The 5-site np.object → object patch in this PR resolves it cleanly — verified end-to-end on 12 ARC libraries (4 K – 35 K cells each).

This PR has been open for 11 months with no review. Modern conda envs uniformly hit this (NumPy 1.24 removed the deprecated alias in Dec 2022), so without the fix AMULET is broken out-of-the-box on a fresh install. Would help a lot to get this merged — happy to provide additional reproduction context if useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants