Fix(grid): make trigger menu button accessible #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinB7
changed the title
CatalinB7
force-pushed
the
fix/aria-expanded
branch
2 times, most recently
from
175784c to
1fb374b
Compare
CatalinB7
changed the title
CatalinB7
requested review from
anbalase and
robertandreimoldoveanu
and removed request for
robertandreimoldoveanu
CatalinB7
force-pushed
the
fix/aria-expanded
branch
from
bdca506 to
563f568
Compare
anbalase
reviewed
Mar 8, 2023
projects/angular/directives/custom-mat-menu-trigger/src/custom-mat-menu-trigger.directive.ts
Outdated
Show resolved
Hide resolved
anbalase
reviewed
Mar 8, 2023
anbalase
reviewed
Mar 8, 2023
anbalase
reviewed
Mar 8, 2023
Collaborator
anbalase
left a comment
anbalase
left a comment
There was a problem hiding this comment.
let's add a FIXME for when we upgrade to 15@latest
anbalase
reviewed
Mar 8, 2023
projects/angular/directives/custom-mat-menu-trigger/src/custom-mat-menu-trigger.directive.ts
Show resolved
Hide resolved
CatalinB7
force-pushed
the
fix/aria-expanded
branch
from
563f568 to
680a95c
Compare
CatalinB7
force-pushed
the
fix/aria-expanded
branch
from
680a95c to
80f3612
Compare
|
Code Climate has analyzed commit 80f3612 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.8% (0.0% change). View more on Code Climate. |
Collaborator
|
On mac's VoiceOver, the |
caleniuc
approved these changes
Mar 9, 2023
gheorghitahurmuz
pushed a commit
that referenced
this pull request
Dec 12, 2023
Fix(grid): make trigger menu button accessible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button triggering the menu from the grid's filters was not announcing the current state collapsed / expanded.
Clicking with the mouse (cursor not visible tho, had to pay for that functionality lol):
20230307223554.mp4
Navigating using only the keyboard:
20230307223851.mp4