Fix/announce dropdown state #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinB7
force-pushed
the
fix/announce_dropdown_state
branch
2 times, most recently
from
ba028ec to
1bcdeb0
Compare
CatalinB7
force-pushed
the
fix/announce_dropdown_state
branch
from
81fd1b6 to
089c66f
Compare
anbalase
requested review from
a team,
alexdudescu and
caleniuc
and removed request for
a team
caleniuc
reviewed
May 3, 2023
| this.menuOpened.pipe( | ||
| takeUntil(this._destroyed$), | ||
| ).subscribe(() => { | ||
| this.nativeElement.setAttribute('aria-expanded', 'false'); |
Collaborator
There was a problem hiding this comment.
Check if we can remove this, since we already call it in ngAfterViewInit
Collaborator
Author
There was a problem hiding this comment.
ty, it was only for testing, should have removed it
CatalinB7
force-pushed
the
fix/announce_dropdown_state
branch
from
089c66f to
ec39c5b
Compare
caleniuc
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒 Cherry pick of this PR with some modifications in order to work on
@angular/material@13.2.1