feat(ui-grid): add support for using a custom search #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @Directive({ | ||
| selector: '[uiGridCustomSearch], ui-grid-custom-search', | ||
| }) | ||
| export class UiGridCustomSearchDirective { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
adrian-macuc
force-pushed
the
feat/uigrid_custom_search
branch
from
b177781 to
12f1aa5
Compare
anbalase
reviewed
Jan 25, 2024
| } from '@angular/core'; | ||
|
|
||
| @Directive({ | ||
| selector: '[uiGridCustomSearch], ui-grid-custom-search', |
Collaborator
There was a problem hiding this comment.
what's the usecase pls for ref?
toxik
approved these changes
Feb 5, 2024
toxik
force-pushed
the
feat/uigrid_custom_search
branch
from
12f1aa5 to
e4d907a
Compare
|
Code Climate has analyzed commit e4d907a and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.3% (0.0% change). View more on Code Climate. |
gheorghitahurmuz
pushed a commit
that referenced
this pull request
Feb 5, 2024
feat(ui-grid): add support for using a custom search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.