feat(apollo-vertex): persist rows per page in data table [AGVSOL-3072]#673
Merged
feat(apollo-vertex): persist rows per page in data table [AGVSOL-3072]#673
Conversation
angeloaltamiranom
requested review from
alincadariu and
frankkluijtmans
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
angeloaltamiranom
changed the title
0xr3ngar
requested changes
May 11, 2026
angeloaltamiranom
force-pushed
the
angeloaltamiranom/persist-rows-per-page
branch
from
56d1f04 to
a0c4a58
Compare
Add usePersistedPageSize hook mirroring usePersistedSorting so the data table's rows-per-page selection survives reload alongside column visibility, sorting, and column order. pageIndex stays ephemeral. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
angeloaltamiranom
force-pushed
the
angeloaltamiranom/persist-rows-per-page
branch
from
a0c4a58 to
e3d3c59
Compare
alincadariu
reviewed
May 11, 2026
Collaborator
alincadariu
left a comment
alincadariu
left a comment
There was a problem hiding this comment.
@angeloaltamiranom the registry ci check is failing 👀
In react-day-picker@9.13.0 the `table` slot was moved to `DeprecatedUI` and removed from the public `ClassNames` type. The registry test installs the calendar component into a fresh app and runs `tsc --noEmit`, which fails with TS2353 on the `table` key. Drop the entry from both the apollo-vertex registry copy and the apollo-wind source to match the current upstream shadcn/ui template; the surrounding flex slots carry the layout, so `border-collapse` is not load-bearing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The date-picker entry referenced `calendar` without a namespace, so `shadcn add` resolved it against the default shadcn registry instead of the local @UiPath registry. The upstream calendar still ships the deprecated `table` className that was removed from react-day-picker@9's public `ClassNames` type, causing the registry test for date-picker to fail even after the @UiPath calendar was patched. Prefix the dependency with `@uipath/` so date-picker picks up our fixed calendar copy. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
frankkluijtmans
approved these changes
May 11, 2026
0xr3ngar
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This comes from a request by Medtronic to be able to persist the page size selection. So in the same way we persist the column selection im thinking we should also persist the page size.
SS