Skip to content

feat(apollo-react): add stage and task status tooltip [MST-10211]#751

Merged
ayush578 merged 1 commit into
mainfrom
feat/addStatusTooltip
May 27, 2026
Merged

feat(apollo-react): add stage and task status tooltip [MST-10211]#751
ayush578 merged 1 commit into
mainfrom
feat/addStatusTooltip

Conversation

@ayush578
Copy link
Copy Markdown
Contributor

added general locale prop to affectively check the localization effect.
added localization to some sticky note left out strings
added stage and tasks status icons tooltip

Screen.Recording.2026-05-26.at.12.56.09.PM.mov

Copilot AI review requested due to automatic review settings May 26, 2026 07:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs May 26, 2026, 10:57:10 PM
apollo-docs 🟢 Ready Preview, Logs May 26, 2026, 10:57:10 PM
apollo-landing 🟢 Ready Preview, Logs May 26, 2026, 10:57:10 PM
apollo-ui-react 🟢 Ready Preview, Logs May 26, 2026, 10:57:10 PM
apollo-vertex 🟢 Ready Preview, Logs May 26, 2026, 10:57:10 PM

@github-actions github-actions Bot added the size:L 100-499 changed lines. label May 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1901 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1671
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds localized execution-status labels for Stage/Task icons (used for tooltip text + aria-label), localizes Sticky Note toolbar actions, and improves Storybook locale switching by driving ApI18nProvider via <html lang>.

Changes:

  • Introduces useExecutionStatusLabel() to map stage/task execution statuses to localized, human-readable labels and uses it in StageNodeHeader and TaskContent.
  • Localizes missing Sticky Note toolbar strings and adds corresponding English catalog entries.
  • Adds a Storybook locale toolbar that updates <html lang> and remounts stories to re-run locale detection.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/apollo-react/src/canvas/locales/en.json Adds English strings for stage/task statuses and Sticky Note toolbar actions.
packages/apollo-react/src/canvas/components/StickyNoteNode/StickyNoteNode.tsx Replaces hardcoded toolbar labels with useSafeLingui() translations.
packages/apollo-react/src/canvas/components/StageNode/useExecutionStatusLabel.ts New hook to localize execution status labels (tooltip + a11y text).
packages/apollo-react/src/canvas/components/StageNode/useExecutionStatusLabel.test.ts Unit tests for the new status→label mapping hook.
packages/apollo-react/src/canvas/components/StageNode/TaskContent.tsx Uses localized status name for tooltip and aria-label on task status icon.
packages/apollo-react/src/canvas/components/StageNode/TaskContent.test.tsx Adds tests validating tooltip/aria-label behavior for task status icon.
packages/apollo-react/src/canvas/components/StageNode/StageNodeHeader.tsx Uses localized status name for aria-label and tooltip fallback.
packages/apollo-react/src/canvas/components/StageNode/StageNode.test.tsx Adds Stage status tooltip/aria-label coverage.
packages/apollo-react/src/canvas/components/StageNode/StageNode.stories.tsx Removes per-story locale arg in favor of global Storybook locale switching.
apps/storybook/.storybook/preview.tsx Adds a locale toolbar; sets <html lang> and remounts stories on locale change.

Comment thread packages/apollo-react/src/canvas/components/StageNode/StageNode.test.tsx Outdated
Comment thread packages/apollo-react/src/canvas/components/StageNode/TaskContent.tsx Outdated
Copy link
Copy Markdown
Contributor

@uipath-utkarsh uipath-utkarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Two findings worth addressing. Both surfaced from independent review passes and verified against the referenced code.

Comment thread apps/storybook/.storybook/preview.tsx
Comment thread packages/apollo-react/src/canvas/components/StageNode/TaskContent.tsx Outdated
Copilot AI review requested due to automatic review settings May 26, 2026 10:58
@ayush578 ayush578 force-pushed the feat/addStatusTooltip branch 3 times, most recently from 0ef3799 to 58f8cff Compare May 26, 2026 11:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment thread apps/storybook/.storybook/preview.tsx
@ayush578 ayush578 force-pushed the feat/addStatusTooltip branch from 58f8cff to 802ab62 Compare May 27, 2026 05:00
Copilot AI review requested due to automatic review settings May 27, 2026 05:29
@ayush578 ayush578 force-pushed the feat/addStatusTooltip branch from 802ab62 to 96a089e Compare May 27, 2026 05:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Comment thread apps/storybook/.storybook/preview.tsx
@ayush578 ayush578 force-pushed the feat/addStatusTooltip branch from 96a089e to 9077291 Compare May 27, 2026 05:52
@ayush578 ayush578 enabled auto-merge (rebase) May 27, 2026 06:06
@ayush578 ayush578 disabled auto-merge May 27, 2026 06:06
@ayush578 ayush578 merged commit 9b89d8b into main May 27, 2026
42 checks passed
@ayush578 ayush578 deleted the feat/addStatusTooltip branch May 27, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants