fix(maestro-case): structured filter tree docs, reference-ID reuse warning#426
Conversation
|
Claude finished @song-zhao-25's task in 2m 27s —— View job SummaryDocumentation-only PR with three targeted fixes to the Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Not modified — no changes to SKILL.md |
| E2E Tests | Pre-existing gap | No e2e-tagged tasks; both existing are smoke. Not introduced by this PR |
| Skill Body | OK | Changes are in reference files only |
| References & Assets | OK | All relative links resolve; no orphaned files; no cross-skill refs |
| Repo Hygiene | OK | CODEOWNERS entry exists; no secrets/paths; changes scoped to one skill |
Issues for Manual Review
- Filter tree schema accuracy: The structured filter tree format (
groupOperator,filters[],groups[], operator names) should be verified against the actual SDK/CLI implementation. The reviewer cannot confirm whether these field names and operator strings match the runtime. - Dynamic variable limitation workaround: Line 142 says to "write the
body.filters.expressionJMESPath string directly" when=vars.Xis needed. Verify this fallback path still works with current CLI versions.
Conclusion
Clean documentation PR. All three fixes are well-scoped, internally consistent, and follow repo conventions. No critical or high issues. One Low observation about the body example potentially being misread. The pre-existing lack of e2e test coverage is worth tracking but not blocking for this PR. Approve.
…rning
1. Structured filter tree (MST-8802 / Skills#304):
- connector-trigger-common.md §7: replace flat JMESPath table with
structured filter tree shape, operators (13 listed + SDK enum ref),
examples (single, multi-AND, nested AND/OR)
- essentialConfiguration: filter is now <filter-tree-or-null>
- Input body: CLI auto-generates JMESPath from tree
- What NOT to Do: "don't hand-write JMESPath" + "don't use filterExpression"
- Dynamic =vars.X limitation documented
2. Reference-ID reuse warning (Skills#348):
- connector-trigger-common.md + connector-activity/impl-json.md:
"Never reuse reference IDs across connections"
3. connector-integration.md: add structured tree note to Filter Syntax section
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e8ae28e to
963bdc3
Compare
…rning (#426) 1. Structured filter tree (MST-8802 / Skills#304): - connector-trigger-common.md §7: replace flat JMESPath table with structured filter tree shape, operators (13 listed + SDK enum ref), examples (single, multi-AND, nested AND/OR) - essentialConfiguration: filter is now <filter-tree-or-null> - Input body: CLI auto-generates JMESPath from tree - What NOT to Do: "don't hand-write JMESPath" + "don't use filterExpression" - Dynamic =vars.X limitation documented 2. Reference-ID reuse warning (Skills#348): - connector-trigger-common.md + connector-activity/impl-json.md: "Never reuse reference IDs across connections" 3. connector-integration.md: add structured tree note to Filter Syntax section Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Two skill doc fixes ported from flow-tool IS changes (identified during flow-to-case connector sync analysis).
1. Structured filter tree (MST-8802 / Skills#304)
connector-trigger-common.md§7: replace flat JMESPath filter table with structured filter tree shape, 13 operators + SDK enum reference, 3 examples (single, multi-AND, nested AND/OR)connector-trigger-common.md§essentialConfiguration:filterfield is now<filter-tree-or-null>, not hardcodednullconnector-trigger-common.md§Input body: note CLI auto-generates JMESPath from treeconnector-trigger-common.md§What NOT to Do: replace "filter stays null" with "don't hand-write JMESPath" + "don't use filterExpression"connector-integration.md: add note that JSON write path uses structured trees=vars.Xlimitation (SDK only supports literal values)2. Reference-ID reuse warning (Skills#348)
connector-trigger-common.md§What NOT to Do: add anti-reuse ruleconnector-activity/impl-json.md§What NOT to Do: add anti-reuse ruleuip is resources execute list"Files changed (3)
skills/uipath-maestro-case/references/connector-trigger-common.mdskills/uipath-maestro-case/references/connector-integration.mdskills/uipath-maestro-case/references/plugins/tasks/connector-activity/impl-json.mdTest plan
connector-trigger-common.mdshows structured filter tree format with operators + examplesessentialConfigurationtemplate uses<filter-tree-or-null>notnullconnector-integration.mdhas structured tree note in Filter Syntax section🤖 Generated with Claude Code