feat: enforce deterministic guardrails tool-level scope#363
Merged
ctiliescuuipath merged 3 commits intomainfrom Dec 19, 2025
Merged
feat: enforce deterministic guardrails tool-level scope#363ctiliescuuipath merged 3 commits intomainfrom
ctiliescuuipath merged 3 commits intomainfrom
Conversation
Contributor
ctiliescuuipath
commented
Dec 18, 2025
- Add scope validation in build_guardrails_with_actions
- Add explicit filtering in LLM/AGENT guardrail subgraph builders
- Improve runtime error messages for invalid scope configurations
- Add comprehensive tests for scope validation
| assert action.version == 2 | ||
| assert action.assignee == "admin@example.com" | ||
|
|
||
| def test_deterministic_guardrail_with_llm_scope_raises_value_error(self) -> None: |
Contributor
There was a problem hiding this comment.
test_deterministic_guardrail_with_llm_scope_raises_value_error and test_deterministic_guardrail_with_agent_scope_raises_value_error can be a single test that is parametrized with the scope (llm or agent) => less code duplication.
valentinabojan
approved these changes
Dec 19, 2025
- Add scope validation in build_guardrails_with_actions - Add explicit filtering in LLM/AGENT guardrail subgraph builders - Improve runtime error messages for invalid scope configurations - Add comprehensive tests for scope validation
a85e1ae to
98e5ed9
Compare
mjnovice
pushed a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.