Skip to content

fix: improve 4xx reporting on context and is tools#714

Merged
andreitava-uip merged 2 commits intomainfrom
fix/tools-4xx-handling
Mar 23, 2026
Merged

fix: improve 4xx reporting on context and is tools#714
andreitava-uip merged 2 commits intomainfrom
fix/tools-4xx-handling

Conversation

@andreitava-uip
Copy link
Contributor

Adds handling for common 4xx issues on context and IS tools.
The non-system category ensures they will no longer trigger alerts

@andreitava-uip andreitava-uip force-pushed the fix/tools-4xx-handling branch from 43bac40 to f587c79 Compare March 23, 2026 06:38

logger = logging.getLogger(__name__)

_CONTEXT_GROUNDING_ERRORS: dict[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be more structures like this with tool specific error messages? If so, maybe it's better to extract them in a separate file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the PR since it looks good, the above is just a suggestion, not blocking merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now I'd say it's better to keep them close to the respective tool.
Extracting all of them in a separate file(s) could be done at a later date if they start introducing too much noise here.

@andreitava-uip andreitava-uip merged commit 74c157b into main Mar 23, 2026
42 checks passed
@andreitava-uip andreitava-uip deleted the fix/tools-4xx-handling branch March 23, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants