fix: improve 4xx reporting on context and is tools#714
Merged
andreitava-uip merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
43bac40 to
f587c79
Compare
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| _CONTEXT_GROUNDING_ERRORS: dict[ |
Contributor
There was a problem hiding this comment.
Will there be more structures like this with tool specific error messages? If so, maybe it's better to extract them in a separate file?
Contributor
There was a problem hiding this comment.
Approved the PR since it looks good, the above is just a suggestion, not blocking merge
Contributor
Author
There was a problem hiding this comment.
for now I'd say it's better to keep them close to the respective tool.
Extracting all of them in a separate file(s) could be done at a later date if they start introducing too much noise here.
dianagrecu-uipath
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling for common 4xx issues on context and IS tools.
The non-system category ensures they will no longer trigger alerts