Added better dependencies to anthropic client#5
Merged
cosminacho merged 6 commits intomainfrom Feb 3, 2026
Merged
Conversation
cosminacho
requested review from
DragosBobolea,
cristipufu and
ionmincu
as code owners
cosminacho
temporarily deployed
to
LLMGW_SETTINGS
GitHub Actions
Inactive
cosminacho
temporarily deployed
to
LLMGW_SETTINGS
GitHub Actions
Inactive
cosminacho
temporarily deployed
to
LLMGW_SETTINGS
GitHub Actions
Inactive
cosminacho
had a problem deploying
to
LLMGW_SETTINGS
GitHub Actions
Error
cosminacho
had a problem deploying
to
LLMGW_SETTINGS
GitHub Actions
Error
cosminacho
requested a deployment
to
LLMGW_SETTINGS
GitHub Actions
In progress
cosminacho
had a problem deploying
to
LLMGW_SETTINGS
GitHub Actions
Error
cosminacho
temporarily deployed
to
LLMGW_SETTINGS
GitHub Actions
Inactive
cosminacho
temporarily deployed
to
LLMGW_SETTINGS
GitHub Actions
Inactive
cosminacho
added a commit
that referenced
this pull request
Apr 1, 2026
Bug #5 — UiPathFireworksEmbeddings: self.model returned wrong model name Without an explicit field override, Pydantic kept two separate fields: FireworksEmbeddings.model (default 'nomic-ai/nomic-embed-text-v1.5') and UiPathBaseLLMClient.model_name (populated by the caller via alias 'model'). self.model therefore always resolved to the stale FireworksEmbeddings default, silently ignoring whatever model name the caller passed. Fix: add model: str = Field(default='', alias='model_name') — the same override pattern used by every other embedding class — to collapse the two fields into one. Replace self.model with self.model_name in all four embed methods. Bug #8 — UiPathEmbeddings: silent HTTP error swallowing + missing model field Two issues in embed_documents / aembed_documents: 1. uipath_request / uipath_arequest were called without raise_status_error=True, so HTTP 4xx/5xx responses were silently accepted. The subsequent response.json()['data'] access would then raise a confusing KeyError or AttributeError rather than a clear HTTP error. 2. The request body only contained {'input': texts}. The normalized API requires a 'model' field for routing, matching the pattern already used by the normalized chat model (_default_params includes 'model'). Fix: pass raise_status_error=True and add 'model': self.model_name to the request body in both the sync and async paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development Package
Add these packages as dependencies in your pyproject.toml: