fix: filter dropped spans in upsert_span to match export behavior#1118
Merged
saksharthakkar merged 1 commit intomainfrom Jan 15, 2026
Merged
fix: filter dropped spans in upsert_span to match export behavior#1118saksharthakkar merged 1 commit intomainfrom
saksharthakkar merged 1 commit intomainfrom
Conversation
Spans marked with telemetry.filter=drop were bypassing filtering when using upsert_span() for live tracking. Now both export() and upsert_span() consistently skip these spans. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
89a6e6e to
dabe5db
Compare
JosephMar
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
OpenInference spans (LangGraph internal nodes like
init,agent,route_agent) were appearing in LLMOps traces despite being marked withtelemetry.filter=drop.The
LlmOpsHttpExporterhad two export paths:export()- batch export, had filtering via_should_drop_span()upsert_span()- real-time upsert for live tracking, missing filteringThe agents package calls
upsert_span()for live visibility, which bypassed the filtering.Fix
Added the same
_should_drop_span()check toupsert_span():Now both paths consistently filter spans marked for dropping.
Test plan
test_upsert_span_filters_dropped_spanspasses🤖 Generated with Claude Code