fix: use new header for folder paths containing non-ascii chars#1451
Merged
dianagrecu-uipath merged 12 commits intomainfrom Mar 19, 2026
Merged
fix: use new header for folder paths containing non-ascii chars#1451dianagrecu-uipath merged 12 commits intomainfrom
dianagrecu-uipath merged 12 commits intomainfrom
Conversation
github-actions
bot
added
the
test:uipath-langchain
dianagrecu-uipath
force-pushed
the
fix/http-headers-sanitization
branch
from
7a7b079 to
2e57a11
Compare
dianagrecu-uipath
force-pushed
the
fix/http-headers-sanitization
branch
from
d7c0501 to
78016f6
Compare
github-actions
bot
added
the
test:uipath-llamaindex
dianagrecu-uipath
force-pushed
the
fix/http-headers-sanitization
branch
from
3baf065 to
53d15da
Compare
radu-mocanu
reviewed
Mar 19, 2026
| app_folder_key: Optional[str], app_folder_path: Optional[str] | ||
| ) -> Dict[str, str]: | ||
| headers = {} | ||
| headers: Dict[str, str] = {} |
Collaborator
There was a problem hiding this comment.
nit: let's use python built-in primitives for types
Suggested change
| headers: Dict[str, str] = {} | |
| headers: dict[str, str] = {} |
andreiancuta-uipath
approved these changes
Mar 19, 2026
radu-mocanu
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a solution name contains non-ascii characters, these will get in the x-uipath-folder-path header value, breaking the spec requiring headers to have only ascii chars.
Solution: For solutions that contain non-ascii characters the x-uipath-folder-path-encoded header needs to be used instead of x-uipath-folder-path.