Some legacy evaluators do not support target output key#1453
Draft
minion-workers[bot] wants to merge 1 commit intomainfrom
Draft
Some legacy evaluators do not support target output key#1453minion-workers[bot] wants to merge 1 commit intomainfrom
minion-workers[bot] wants to merge 1 commit intomainfrom
Conversation
Resolves #1217 Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Minion Review Gate: Starting review (round 1). Watch live |
Author
|
Minion Review Gate: Changes requested. The implementer agent will address the issues above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1217
Here's a summary of the changes made:
Changes
Problem: Legacy evaluators had duplicated
target_output_keyresolution logic scattered across individual evaluators, and the pattern wasn't consistently applied.Solution: Added a centralized
get_targeted_field(self, obj)method toBaseLegacyEvaluatorand refactored all three evaluators that use target output key resolution to call it.Files changed (4 files, +20/-61 lines):
base_legacy_evaluator.py— Addedget_targeted_field()method that resolvestarget_output_keyviaresolve_output_path, returning the original object on failure. Added theresolve_output_pathimport.legacy_llm_as_judge_evaluator.py— Replaced 13 lines of inline resolution with 2 calls toself.get_targeted_field(). Removed unusedresolve_output_pathimport.legacy_exact_match_evaluator.py— Replaced 20 lines of inline resolution (with special coupled failure handling) with 2 calls toself.get_targeted_field(). Removed unused import.legacy_json_similarity_evaluator.py— Replaced 12 lines of inline resolution with 2 calls toself.get_targeted_field(). Removed unused import.All 148 existing tests pass and lint/format checks are clean.
Changes
Files changed
Created by Minion Worker — autonomous Claude Code agent
To request changes, comment mentioning
@minion.