fix: handle unserializable objects in serialize_defaults#1527
Merged
Conversation
Wrap the core logic in _serialize_defaults_inner and catch any exception in the outer serialize_defaults, falling back to str(). This prevents serialization failures (e.g. copy.deepcopy on unpicklable objects like _queue.SimpleQueue in httpx clients) from crashing callers like tracing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
radugheo
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serialize_defaultscore logic in_serialize_defaults_innerwith a top-level try/except that falls back tostr(obj)on any failurecopy.deepcopyon unpicklable objects like_queue.SimpleQueuein httpx clients) from crashing callers like the tracing decoratordataclasses.asdict()usescopy.deepcopyinternally, which fails when a dataclass (like LangGraph'sToolCallRequest) contains objects with unpicklable stateTest plan
SimpleQueuefield🤖 Generated with Claude Code