fix(mocks): pass invocation as a tuple to avoid arg name collisions#1585
Merged
akshaylive merged 1 commit intomainfrom Apr 22, 2026
Merged
fix(mocks): pass invocation as a tuple to avoid arg name collisions#1585akshaylive merged 1 commit intomainfrom
akshaylive merged 1 commit intomainfrom
Conversation
A function decorated with `@mockable` previously errored if it had an argument named `func` or `params`, because those names collided with positional parameters on the internal `response()` and `get_mocked_response()` signatures when user kwargs were spread through. Bundle `(args, kwargs)` into a single `invocation` positional argument so user kwargs are never spread across internal signatures. This removes the collision entirely for any user argument name. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
test:uipath-langchain
maxduu
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function decorated with
@mockablepreviously errored if it had an argument namedfuncorparams, because those names collided with positional parameters on the internalresponse()andget_mocked_response()signatures when user kwargs were spread through.Bundle
(args, kwargs)into a singleinvocationpositional argument so user kwargs are never spread across internal signatures. This removes the collision entirely for any user argument name.