Merged
Conversation
DragosBobolea
added a commit
that referenced
this pull request
Mar 27, 2026
_not_found: - Change return type -> NoReturn (unconditionally raises; None was a false-negative for type checkers and caused 'index possibly unbound' warnings at call sites in ingest/delete) - Update docstring to accurately describe the single responsibility: classify not-found vs other, re-raise as ClickException search: - Rename --results to --limit (-n) — more conventional (az/gcloud/aws all use --limit for a max-count option) - Update all examples in docstring and help text ingest: - Check index.in_progress_ingestion() immediately after retrieve() to fail fast without a redundant HTTP round-trip (issue #4) - Add test_ingest_already_in_progress_fast_fail covering this path and asserting ingest_data is never called delete: - Wrap delete_index() in try/except to surface 403/404 race conditions as clean ClickException rather than raw error (issue #5) contract tests: - Replace fragile 'not service.startswith(context)' heuristic with an explicit NESTED_SERVICES set — adding future services can't silently break the navigation logic (issue #6) tests: - Remove dead mock_client.context_grounding.retrieve.return_value from test_search_basic and test_search_with_results_option (search doesn't call retrieve; issue #11) - Rename test_search_with_results_option -> test_search_with_limit_option - Add comment in test_search_empty_results explaining err=True / CliRunner stderr mixing (issue #12) - _make_index now configures in_progress_ingestion.return_value = False so the new fast-fail guard doesn't trip in unrelated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.