Skip to content

fix: display trace spans in terminal realtime#525

Merged
cristipufu merged 1 commit intomainfrom
fix/terminal_display_trace_spans
Sep 2, 2025
Merged

fix: display trace spans in terminal realtime#525
cristipufu merged 1 commit intomainfrom
fix/terminal_display_trace_spans

Conversation

@cristipufu
Copy link
Copy Markdown
Member

No description provided.

@cristipufu cristipufu self-assigned this Sep 2, 2025

This comment was marked as outdated.

@cristipufu cristipufu force-pushed the fix/terminal_display_trace_spans branch from 11933fe to 4830b4d Compare September 2, 2025 16:27
@cristipufu cristipufu requested a review from Copilot September 2, 2025 16:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the display of trace spans in terminal realtime by optimizing the span tree building algorithm. The changes refactor the logic to handle artificial root spans properly and improve performance through better data structure usage.

Key changes:

  • Optimized span tree building algorithm for better performance
  • Improved handling of artificial root spans by filtering them out
  • Refactored recursive tree building logic for cleaner code structure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/uipath/_cli/_dev/_terminal/_components/_details.py Refactored _build_spans_tree method to filter artificial root spans and optimized tree building with prebuilt parent-to-children mapping
pyproject.toml Version bump from 2.1.30 to 2.1.31

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/uipath/_cli/_dev/_terminal/_components/_details.py
Comment thread src/uipath/_cli/_dev/_terminal/_components/_details.py
@cristipufu cristipufu force-pushed the fix/terminal_display_trace_spans branch from 4830b4d to 91eaa5d Compare September 2, 2025 16:29
@cristipufu cristipufu force-pushed the fix/terminal_display_trace_spans branch from 91eaa5d to 63e7f49 Compare September 2, 2025 17:53
@cristipufu cristipufu merged commit 54a6cfd into main Sep 2, 2025
16 checks passed
@cristipufu cristipufu deleted the fix/terminal_display_trace_spans branch September 2, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants