Skip to content

Conversation

@cristipufu
Copy link
Member

@cristipufu cristipufu commented Sep 6, 2025

Description

This PR fixes traceback display in terminal error logs by enhancing the logging system to support rich traceback rendering instead of simple error messages.

  • Modified LogMessage to accept both strings and Rich renderables for enhanced error display
  • Updated error logging to generate Rich Traceback objects with detailed stack traces and local variables
  • Enhanced log display logic to handle both string messages and Rich renderables appropriately
image image

Development Package

  • Add this package as a dependency in your pyproject.toml:
[project]
dependencies = [
  # Exact version:
  "uipath==2.1.36.dev1005470941",

  # Any version from PR
  "uipath>=2.1.36.dev1005470000,<2.1.36.dev1005480000"
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath = { index = "testpypi" }

@cristipufu cristipufu requested a review from Copilot September 6, 2025 10:31
@cristipufu cristipufu self-assigned this Sep 6, 2025
@cristipufu cristipufu added the build:dev Create a dev build from the pr label Sep 6, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes traceback display in terminal error logs by enhancing the logging system to support rich traceback rendering instead of simple error messages.

  • Modified LogMessage to accept both strings and Rich renderables for enhanced error display
  • Updated error logging to generate Rich Traceback objects with detailed stack traces and local variables
  • Enhanced log display logic to handle both string messages and Rich renderables appropriately

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/uipath/_cli/_dev/_terminal/_models/_messages.py Updated LogMessage to accept Union[str, RenderableType] for message parameter
src/uipath/_cli/_dev/_terminal/_components/_details.py Added conditional rendering logic to handle both string and Rich renderable messages
src/uipath/_cli/_dev/_terminal/__init__.py Replaced simple error strings with Rich Traceback objects in error logging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cristipufu cristipufu force-pushed the fix/proper_error_logs branch from 502ce27 to 1a4fae1 Compare September 6, 2025 10:53
@cristipufu cristipufu merged commit 4937e66 into main Sep 6, 2025
16 checks passed
@cristipufu cristipufu deleted the fix/proper_error_logs branch September 6, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:dev Create a dev build from the pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant