fix(httpx_header): allow httpx determine the correct header#563
Merged
fix(httpx_header): allow httpx determine the correct header#563
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an httpx header issue by allowing httpx to determine the correct content-type header automatically instead of manually setting it. The change replaces manual string content serialization with proper JSON serialization using the json parameter.
- Removes hardcoded "Content-Type": "application/json" from default headers
- Converts manual string content creation to proper JSON serialization using
jsonparameter - Updates test assertions to use
json.dumps()with consistent separators for comparison - Adds proper
paramsandjsonparameter handling to request calls
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/uipath/_services/_base_service.py | Removes hardcoded Content-Type header and adds RequestSpec handling methods |
| src/uipath/_services/processes_service.py | Converts manual content string to json parameter and adds proper request parameters |
| src/uipath/_services/assets_service.py | Converts content strings to json parameters and adds proper request handling |
| src/uipath/_services/actions_service.py | Removes manual JSON serialization in favor of json parameter and updates request calls |
| tests/sdk/services/test_base_service.py | Updates test expectations to remove Content-Type header assertion |
| tests/sdk/services/test_processes_service.py | Updates test assertions to use json.dumps() for consistent JSON comparison |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8f84459 to
55d65a6
Compare
17d36d7 to
12e9afc
Compare
ionmincu
approved these changes
Sep 15, 2025
12e9afc to
2c1870c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #508
Development Package