Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the terminal trace tree view by changing how the spans tree is cleared during rebuilds. The fix replaces the clear() method with root.remove_children() to properly reset the tree structure.
- Replaces
spans_tree.clear()withspans_tree.root.remove_children()
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cristipufu
force-pushed
the
fix/terminal_traces_view
branch
from
9c7ee56 to
0910698
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the terminal trace tree view by changing how the spans tree is cleared during rebuilds. The fix replaces the
clear()method withroot.remove_children()to properly reset the tree structure.