Dehardcode account providers#38
Merged
Merged
Conversation
Neptune650
reviewed
Jun 14, 2021
Neptune650
previously requested changes
Jun 14, 2021
Neptune650
approved these changes
Jun 14, 2021
Collaborator
Author
|
@sebastian-byte @AfoninZ Please review and do some tests |
Collaborator
|
Creating accounts works for me, no launch problems on the Linux build, I approve |
zaafonin
approved these changes
Jun 14, 2021
max8rr8
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently account providers (mojang, elyby and dummy) are hardcoded. This pull request moves each account provider to separate class.