Skip to content

Update the workflow#2326

Merged
HellAholic merged 10 commits intomainfrom
CURA-13110_gcodeAnalyzerWorkflow
Apr 28, 2026
Merged

Update the workflow#2326
HellAholic merged 10 commits intomainfrom
CURA-13110_gcodeAnalyzerWorkflow

Conversation

@HellAholic
Copy link
Copy Markdown
Contributor

@HellAholic HellAholic commented Apr 16, 2026

Make the workflow ticket aware across different repositories (including the GcodeAnalyzer)
Moving the script to execute the analyzer to its own repository (to do item) to keep all the connected elements in one place for the analyzer
Using the cura.jinja profile for the build to include the overrides

  • Package override action, checks for existing tag before appending it. Required to be fixed to prevent a duplicated tag error Ultimaker/cura-workflows@038066f
  • cura.jinja, move the override section to the bottom of the file so we can just append the overrides when required without needing to add the override tag Ultimaker/conan-config@64a4beb

CURA-13110
Requires Ultimaker/Cura#21563

Make the workflow ticket aware across different repositories (including the GcodeAnalyzer)
Moving the script to execute the analyzer to its own repository (to do item) to keep all the connected elements in one place for the analyzer
Using the cura.jinja profile for the build to include the overrides
- Package override action, checks for existing tag before appending it. Required to be fixed to prevent a duplicated tag error Ultimaker/cura-workflows@038066f
- cura.jinja, move the override section to the bottom of the file so we can just append the overrides when required without needing to add the override tag Ultimaker/conan-config@64a4beb
@HellAholic HellAholic marked this pull request as ready for review April 16, 2026 11:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Test Results

31 tests  ±0   31 ✅ ±0   4s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f991aac. ± Comparison against base commit 7f104ce.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some suggestion and questions

Comment thread .github/workflows/gcodeanalyzer.yml Outdated
Comment thread .github/workflows/gcodeanalyzer.yml Outdated
Comment thread .github/workflows/gcodeanalyzer.yml
Comment thread .github/workflows/gcodeanalyzer.yml Outdated
HellAholic and others added 6 commits April 16, 2026 14:57
Co-authored-by: Erwan MATHIEU <erwan.mathieu@ultimaker.com>
Co-authored-by: Erwan MATHIEU <erwan.mathieu@ultimaker.com>
always ensures the if condition is validated before failing the job, but since the job requires the output of the previous jobs it becomes a redundant check to execute in case of a fail job
Copy link
Copy Markdown
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! However the GCodeAnalyzer failed to execute, which is precisely the point of the PR 😄 I will take a look

@HellAholic HellAholic merged commit 4dffb0c into main Apr 28, 2026
36 of 38 checks passed
@HellAholic HellAholic deleted the CURA-13110_gcodeAnalyzerWorkflow branch April 28, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants