This repository was archived by the owner on Mar 6, 2025. It is now read-only.
Conversation
added 19 commits
May 28, 2019 13:25
STAR-620
woosie10
changed the title
ImreBognarUltimaker
changed the title
ImreBognarUltimaker
changed the title
| > | ||
| <nav | ||
| className="navigation__container" | ||
| role="navigation" |
Contributor
There was a problem hiding this comment.
It is not necessary to add navigation role to a nav element.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Navigation_Role
| private _onCloseMobileMenuHandler(): void { | ||
| const { onCloseMobileMenuHandler } = this.props; | ||
|
|
||
| if (onCloseMobileMenuHandler) { |
Contributor
There was a problem hiding this comment.
The else of this if is not covered by the tests.
ImreBognarUltimaker
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds sub navigation as well as refactoring the existing navigation into smaller components.
The design is based on the following design, but kept more inline with our current style.
https://app.zeplin.io/project/5b18f693e66f3e4636a2a54a/screen/5cdea856407b951d80b99613