Review followup: PR #781 — Bugfix/base gateway return type compat

[superdav42]

Unaddressed review bot suggestions

PR #781 was merged with unaddressed review bot feedback.
Source PR: #781

Actionable comments

• coderabbitai[bot] (AGENTS.md): ⚠️ Potential issue | 🟡 Minor Document the checkout scope consistently. This narrows the rule to inc/checkout/signup-fields/, but the repository guideline still applies it to all of `inc/ch...
• coderabbitai[bot] (inc/gateways/class-base-gateway.php): ⚠️ Potential issue | 🔴 Critical
  🧩 Analysis chain

  🌐 Web query: `In PHP 7.4+, if a parent class method is declared without a parameter type, can a child override it w...
• coderabbitai[bot] (inc/integrations/interface-capability-module.php): ⚠️ Potential issue | 🔴 Critical
  🧩 Analysis chain

  🌐 Web query: In PHP 7.4+, if an interface declares public function supports($feature);`, can an implementing clas...
• coderabbitai[bot]: Actionable comments posted: 3 > [!CAUTION] > Some comments are outside the diff and can’t be posted inline due to platform limitations. > > > >
  >

  ⚠️ Outside diff range comme...

---

aidevops.sh v3.8.1 with claude-sonnet-4-6 spent 1h 39m and 8 tokens on this as a headless worker.

[superdav42]

DISPATCH_CLAIM nonce=9762e13c7433e7383a008485137110ca runner=superdav42 ts=2026-04-13T04:36:32Z max_age_s=1800

[superdav42]

Dispatching worker (deterministic).

• Worker PID: 559208
• Model: anthropic/claude-sonnet-4-6
• Tier: standard
• Runner: superdav42
• Issue: Review followup: PR #781 — Bugfix/base gateway return type compat #809

[superdav42]

Summary

Addresses unresolved CodeRabbit review feedback from PR #781 (merged with open findings).

Critical fixes

Restore removed parameter type declarations (PHP contravariance violation):
PR #781 incorrectly removed parameter types from two Base_Gateway methods. When a parent method is untyped, child overrides cannot declare narrower types without a fatal Declaration must be compatible error. Existing addons with typed overrides would fatal on upgrade.

• Base_Gateway::verify_and_complete_payment(int $payment_id) — restored int
• Base_Gateway::redirect_with_error(string $message) — restored string
  Restore string parameter type on Capability_Module::supports():
  Same contravariance issue: the interface supports(string $feature) had string removed. Implementations that already declare supports(string $feature) (including class-integration.php) would have fatalled.
• Capability_Module::supports(string $feature) — restored string

Minor fixes (missed in PR #781)

Remaining return type declarations on extensible host provider classes:

• CPanel_Host_Provider::detect() — removed : bool
• CPanel_Host_Provider::get_site_url() — removed : string
• Cloudflare_Host_Provider::detect() — removed : bool
  PHPDoc correction:
• Billing_Info_Element::output() — @return updated from string to void (method renders via side effects, uses bare return;)

Documentation fix (AGENTS.md)

The "Type hints" rule narrowly referenced inc/checkout/signup-fields/ but the actual guideline covers inc/checkout/ broadly. Updated to match the intended scope.

Runtime Testing

Risk: Low — PHP parameter/return type declarations only. No logic changes. All changes are backward-compatible with existing subclasses (bundled Stripe and PayPal gateways use untyped $payment_id which is valid widening when parent declares int).
Verified: php -l clean on all 5 modified files.

Files Modified

• EDIT: AGENTS.md:93-94 — expand scope reference
• EDIT: inc/gateways/class-base-gateway.php:597,826 — restore param types
• EDIT: inc/integrations/interface-capability-module.php:59 — restore string param
• EDIT: inc/integrations/host-providers/class-cpanel-host-provider.php:100,265 — remove return types
• EDIT: inc/integrations/host-providers/class-cloudflare-host-provider.php:147 — remove return type
• EDIT: inc/ui/class-billing-info-element.php:269 — fix PHPDoc

---

aidevops.sh v3.8.5 plugin for OpenCode v1.3.16 with claude-sonnet-4-6 spent 6m and 21,124 tokens on this as a headless worker.

---

Merged via PR #816 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).