fix: remove duplicate jsonSerialize() in Note class

[superdav42]

Summary

• Removes duplicate jsonSerialize() method in Note class that causes PHP Fatal: Cannot redeclare WP_Ultimo\Objects\Note::jsonSerialize() on PHP 8.2, 8.4, and 8.5
• Same root cause as the Limitations fix in 7c66017 — two PRs (fix(api): serialize Notes, Limitations, description, Membership meta + fix admin fatal error + CI for fork PRs #491 and fix: resolve 3 REST API serialization bugs #503) both solving issue REST API: description returns null, notes and limitations not JSON-serializable #490 were merged in sequence without rebasing, each adding their own jsonSerialize()

Root Cause Analysis

1. PR fix: resolve 3 REST API serialization bugs #503 (c0b1a630) added jsonSerialize() after to_array() with @since 2.0.11
2. PR fix(api): serialize Notes, Limitations, description, Membership meta + fix admin fatal error + CI for fork PRs #491 (bd384940) added a second jsonSerialize() before to_array() with @since 2.0.0
3. PR fix(api): serialize Notes, Limitations, description, Membership meta + fix admin fatal error + CI for fork PRs #491 was merged ~30 minutes after PR fix: resolve 3 REST API serialization bugs #503, creating the duplicate
4. Commit 7c66017e fixed the identical issue in Limitations but missed Note
5. PHP 8.3 happens to pass (likely due to test ordering/coverage), while 8.2, 8.4, and 8.5 fatal

Why This Wasn't Caught

The main branch has no branch protection rules. This means:

• PRs can be merged without passing CI status checks
• Direct pushes to main are allowed
• No required reviews before merge

Recommended Protections

To prevent this class of bug from reaching main:

1. Enable branch protection on main with:
   • Require status checks to pass before merging (specifically the PHP 8.2, PHP 8.4, PHP 8.5 jobs from tests.yml)
   • Require branches to be up to date before merging (this would have caught the conflict between fix(api): serialize Notes, Limitations, description, Membership meta + fix admin fatal error + CI for fork PRs #491 and fix: resolve 3 REST API serialization bugs #503)
   • Require at least 1 approving review
2. Consider adding a PHP lint CI step (php -l) that catches syntax/redeclaration errors before the full test suite runs

Testing

• php -l inc/objects/class-note.php passes
• No other duplicate jsonSerialize() methods exist in the codebase
• CI should now pass on all PHP versions (8.2, 8.3, 8.4, 8.5)

[coderabbitai]

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1907f05e-5b63-4683-8219-c9c99bb20615

📥 Commits

Reviewing files that changed from the base of the PR and between c575cbd and ffd892d.

📒 Files selected for processing (1)

• inc/objects/class-note.php

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/fix-duplicate-jsonserialize-note

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

• Build: ultimate-multisite
• ⬇️ Download from GitHub Actions
• ⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

[github-actions]

Performance Test Results

Performance test results for c603cf2 are in 🛎️!

URL: /

Run	DB Queries	Memory	Before Template	Template	WP Total	LCP	TTFB	LCP - TTFB
0	57	36.39 MB	299.00 ms	103.00 ms	402.00 ms	492.20 ms	416.20 ms	76.10 ms
1	57	36.39 MB	296.00 ms	101.00 ms	397.00 ms	487.40 ms	410.35 ms	76.45 ms