Skip to content

fix: use _ajax_nonce for network-activate AJAX handler (#836) #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 2 commits into from
Apr 15, 2026
Merged

fix: use _ajax_nonce for network-activate AJAX handler (#836) #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52aff0f
fix: move network-activate handler to external JS file (#836)
superdav42 Apr 15, 2026
3ee7cc6
merge: resolve conflicts with main (keep _ajax_nonce fix, adopt _inst…
superdav42 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/js/network-activate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jQuery(function($) {

var $btn = $(this);
var $wrapper = $btn.closest('div');
var nonce = $btn.data('nonce');
var nonce = $btn.data('ajax-nonce');
var $spinner = $wrapper.find('.wu-network-activate-spinner');
var $message = $wrapper.find('.wu-network-activate-message');
var $fallback = $wrapper.find('.wu-network-activate-fallback');
Expand All @@ -30,7 +30,7 @@ jQuery(function($) {
ajaxurl,
{
action: 'wu_setup_network_activate',
nonce: nonce,
_ajax_nonce: nonce,
},
function(response) {

Expand Down
8 changes: 6 additions & 2 deletions inc/admin-pages/class-setup-wizard-admin-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,18 @@ public function __construct() {
*/
public function ajax_network_activate(): void {

check_ajax_referer('wu_setup_network_activate', 'nonce');

if ( ! current_user_can('manage_network')) {
wp_send_json_error(new \WP_Error('not-allowed', __('Permission denied.', 'ultimate-multisite')));

exit;
}

if ( ! check_ajax_referer('wu_setup_network_activate', false, false)) {
wp_send_json_error(new \WP_Error('bad-nonce', __('Security check failed. Please reload the page and try again.', 'ultimate-multisite')));

exit;
}

try {
Multisite_Network_Installer::get_instance()->_install_network_activate();
} catch (\Throwable $e) {
Expand Down
6 changes: 3 additions & 3 deletions tests/WP_Ultimo/Admin_Pages/Setup_Wizard_Admin_Page_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,12 +453,12 @@ public function test_constructor_registers_network_activate_ajax_action(): void
}

// -------------------------------------------------------------------------
// ajax_network_activate() — permission guard
// ajax_network_activate() — permission guard (checked before nonce)
// -------------------------------------------------------------------------

public function test_ajax_network_activate_sends_json_error_without_permission(): void {
// Provide a valid nonce so the nonce check passes, isolating the permission check.
$_REQUEST['nonce'] = wp_create_nonce('wu_setup_network_activate');
// Capability check fires before nonce check, so no nonce needed to
// isolate this path — an unauthenticated user is rejected immediately.
wp_set_current_user(0);
$this->expectException(\WPAjaxDieStopException::class);
$this->page->ajax_network_activate();
Expand Down
2 changes: 1 addition & 1 deletion views/wizards/setup/requirements_table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<button
type="button"
class="button button-primary wu-network-activate-btn"
data-nonce="<?php echo esc_attr($req['network_activate_nonce']); ?>"
data-ajax-nonce="<?php echo esc_attr($req['network_activate_nonce']); ?>"
>
<?php esc_html_e('Network Activate', 'ultimate-multisite'); ?>
</button>
Expand Down
Loading