Preserve set_extent across ticklen format
#518
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Failures of the tests can be ignored btw -- docs are fixed on a different PR. |
cvanelteren
changed the title
set_extent across ticklen format
beckermr
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #517
This PR fixes a cartopy GeoAxes regression where calling
format(..., ticklen=...)would silently override a previously setset_extent()by reapplying_update_extent()with the label-padding expansion. The new logic only refreshes extent when the user explicitly passes extent-related arguments (lonlim/latlim/boundinglat). Otherwise, tick length updates preserve the current extent by reapplying the existing view intervals. A regression test is included to ensureset_extent()remains stable across ticklen-only format calls.