Internal: Refactor colorbar to decouple from axis. Introduces UltraColorbar and UltraColorbarLayout #529
+1,144
−814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvanelteren
changed the title
This reverts commit 96f3403.
Collaborator
Author
|
Failing tests are not related to the PR (directly -- there is a slight layout drift that I still need to address). |
Collaborator
Author
|
For example: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the colorbar logic to remove it from the
baseandfigureclass to ensure that we focus our efforts on the logic rather than mixing axis handling with colorbar handling. It achieves this by introducing a new modulecolorbarand with it two essential classesUltraColorbarandUltraColorbarlayout.This PR will mark the first step towards this, and the legend object will need a similar rework.