ported umbootstrap to v15)#257
Merged
deanleigh merged 1 commit intoUmTemplates:Upgrade-Umbraco-from-13.4.0-15.2.1from Jun 20, 2025
Merged
ported umbootstrap to v15)#257deanleigh merged 1 commit intoUmTemplates:Upgrade-Umbraco-from-13.4.0-15.2.1from
deanleigh merged 1 commit intoUmTemplates:Upgrade-Umbraco-from-13.4.0-15.2.1from
Conversation
Collaborator
|
Hi Matthew, That's amazing! Please bear with me as I need to remember how to make this Umbraco Version specific. |
There was a problem hiding this comment.
Pull Request Overview
This PR ports the Umbootstrap site to Umbraco v15 by updating view templates, migration to minimal hosting, and bumping project dependencies.
- Refactored Razor views to use strongly-typed block models and property shortcuts
- Replaced Startup.cs with minimal hosting in Program.cs and added BootUmbracoAsync
- Upgraded target framework to .NET 9 and updated package references in the .csproj
Reviewed Changes
Copilot reviewed 391 out of 391 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Views/Partials/blockgrid/Components/featureInternalLinksChildren.cshtml | Use AssignedContentItem and strongly-typed property access |
| Views/Partials/blockgrid/Components/featureInternalLinks.cshtml | Switched to generic BlockGridItem and props |
| Views/Partials/blockgrid/Components/featureImage.cshtml | Updated inheritance and added alt attribute for accessibility |
| Views/Partials/blockgrid/Components/featureHTML.cshtml | Access HTML property via generated model property |
| Views/Partials/blockgrid/Components/featureFormContactUs.cshtml | Updated inheritance to use FeatureFormContactUs generic |
| Views/Partials/blockgrid/Components/featureFAQs.cshtml | Access FAQ items via model property |
| Views/Partials/blockgrid/Components/featureCode.cshtml | Access code snippet via model property |
| Views/Partials/blockgrid/Components/_Layout_Layouts.cshtml | Simplified null checks and unified Settings access |
| Views/Partials/blockgrid/Components/_Layout_Features.cshtml | Simplified Settings checks and var declarations |
| Views/Home.cshtml | Updated block grid call to use Model.ContentGrid |
| Views/Head/_meta.cshtml | Made baseUrl constant and improved null safety on thumbnail URL |
| Views/FeaturesGlobal/header.cshtml | Refactored navigation logic, current page retrieval, and DI usage |
| Umbootstrap.Web.csproj | Bumped to .NET 9, updated Umbraco v15 packages, removed legacy refs |
| Startup.cs | Removed legacy Startup class (migrated to Program.cs) |
| Program.cs | Introduced minimal hosting builder, BootUmbracoAsync and endpoints |
| Extensions/UmbNavExtensions.cs | Added IsActive extension for UmbNav with minLevel parameter |
| Extensions/PublishedContentExtensions.cs | Removed old GetBlocksWithGroupNames extension |
| BlockPreviews/BlockPreviewComposer.cs | Added BlockPreviewComposer for block grid previews |
Comments suppressed due to low confidence (4)
Umbootstrap.Web/Views/Partials/blockgrid/Components/_Layout_Layouts.cshtml:53
- This should be an
else ifso that the background-image style doesn’t overwrite a background-color when both are set.
if (backgroundImage != null)
Umbootstrap.Web/Views/FeaturesGlobal/header.cshtml:13
- Remove the extra closing parenthesis after
GetCropUrl()to fix the Razor syntax error.
<img src="@Model.Logo?.GetCropUrl())" alt="" />
Umbootstrap.Web/Views/FeaturesGlobal/header.cshtml:46
[]is not a valid C# literal; useEnumerable.Empty<UmbNavItem>()orArray.Empty<UmbNavItem>()for an empty sequence.
@foreach (var subItem in menuItem.Children ?? [])
Umbootstrap.Web/Views/FeaturesGlobal/header.cshtml:48
subItem.IsActiverequirescurrentPageandminLevelparameters; update call to something likesubItem.IsActive(currentPage, 2).
<li><a class="dropdown-item @Html.If(subItem.IsActive, "active")" href="@subItem.Url()">@subItem.Name</a></li>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dean,
Here is a v15 version of Umbootstrap it looks feature complete as far as I can tell :D
Hopefully I am right
Thanks
Matt