Skip to content

Pranav2 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Pranav2 #61

wants to merge 3 commits into from

Conversation

@Pranavv213
Copy link

@Pranavv213 Pranavv213 commented Apr 4, 2022

Book Reader changes made

Umesh-01
Umesh-01 requested changes Apr 6, 2022
View reviewed changes
PA.py
elif 'open notepad' in query:
os.startfile("C:\\Windows\\notepad.exe")

os.startfile("C:\\Users\\91954\\AppData\\Roaming\\Microsoft\\Windows\\"
Copy link
Owner

@Umesh-01 Umesh-01 Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
os.startfile("C:\\Users\\91954\\AppData\\Roaming\\Microsoft\\Windows\\"
os.startfile("C:\\Windows\\notepad.exe")

PA.py
os.startfile("C:\\Windows\\notepad.exe")

os.startfile("C:\\Users\\91954\\AppData\\Roaming\\Microsoft\\Windows\\"
"Start Menu\\Programs\\Accessories\\Notepad")
Copy link
Owner

@Umesh-01 Umesh-01 Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Start Menu\\Programs\\Accessories\\Notepad")

PA.py

elif 'open notepad' in query:
os.startfile("C:\\Windows\\notepad.exe")

Copy link
Owner

@Umesh-01 Umesh-01 Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@Pranavv213
Copy link
Author

Pranavv213 commented Apr 7, 2022

This issue is not mine. Opening notepad is someone else issue. Plz check.
My issue was to add Book Reader feature in PA.py which I have already done and made pull request which has no merge conflicts. PLz see to it and merge my pull request for book reader.

@Umesh-01
Copy link
Owner

Umesh-01 commented Apr 7, 2022

This issue is not mine. Opening notepad is someone else issue. Plz check. My issue was to add Book Reader feature in PA.py which I have already done and made pull request which has no merge conflicts. PLz see to it and merge my pull request for book reader.

Yes @Pranavv213 I know that this change was made in different PR but that PR is already merged. May be you haven't pulled the changes from the main branch that's why it is showing the previous code in your branch. Now, you can make the necessary changes, and then I will merge this PR. 👍

Umesh-01
Umesh-01 reviewed May 15, 2022
View reviewed changes
Copy link
Owner

@Umesh-01 Umesh-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranavv213 are you working on this??

@Umesh-01 Umesh-01 removed the GSSoC22 label Jul 27, 2022
@Umesh-01 Umesh-01 closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Umesh-01 Umesh-01 Umesh-01 requested changes

Assignees

@Pranavv213 Pranavv213

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pranavv213 @Umesh-01