[pull] main from calcom:main#1171
Merged
pull[bot] merged 2 commits intoUncodedtech:mainfrom Mar 11, 2026
Merged
Conversation
…dation (#28253) The Dialpad conferencing integration's URL regex only accepted alphanumeric characters in the meeting room path ([a-zA-Z0-9]+), causing valid personal meeting URLs containing hyphens, dots, or underscores to fail validation. For example, https://meetings.dialpad.com/mmit-russ is rejected despite being a valid Dialpad personal meeting link. The sample URL shown in the error message (alphanumeric only) passes, but real-world room names commonly use hyphens and other characters. Updated the urlRegExp character class from [a-zA-Z0-9] to [a-zA-Z0-9._-] to match all valid Dialpad meeting room slugs. Fixes issue introduced in #15444. Co-authored-by: Sahitya Chandra <sahityajb@gmail.com>
Some OIDC providers like Keycloak (v18+) include an `iss` (issuer) parameter in the authentication response for security (as per RFC 9207). The oidc route was explicitly extracting only `code` and `state`, thus losing the `iss` parameter and other potential parameters like `session_state`. When Jackson passed the incomplete set of parameters to `openid-client`, the library failed validation with the error `invalid response encountered` because it expected the `iss` parameter to be present if the server supports it. Fixes #22238. Co-authored-by: Sahitya Chandra <sahityajb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )