[pull] master from flameshot-org:master#238
Merged
pull[bot] merged 3 commits intoUncodedtech:masterfrom May 7, 2026
Merged
Conversation
) * screengrabber: pass non-empty parent_window to xdg-desktop-portal xdg-desktop-portal-gnome on GNOME 46 rejects requests where the parent_window argument is an empty string with the error "Failed to associate portal window with parent window ''", which made daemon-mode (tray icon, DBus captureScreen) capture fail for all GNOME Wayland users. Allocate an offscreen QWidget (Qt::WA_DontShowOnScreen) so a winId is generated, and pass "x11:<hex>" on X11 sessions or "wayland:" on Wayland. Both are accepted by xdg-desktop-portal as valid no-real-parent handles, while remaining non-empty as the portal spec requires. Tested on: Ubuntu 24.04, GNOME 46 Wayland, NVIDIA proprietary 590.48.01, Qt 6.4.2, xdg-desktop-portal-gnome 46.2. Fixes daemon-mode capture on GNOME 46 Wayland. * clang format --------- Co-authored-by: Jeremy Borgman <borgman.jeremy@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )