[pull] master from monkeytypegame:master#878
Merged
Merged
Conversation
…lock, @fehmer) (#7900) ### Description This PR: Migrates the Edit Profile modal to a SolidJS component #### Changes Made: * Added the new SolidJS + Tanstack EditProfile popup component * Sends the updated profile details to the backend when the form is saved * Immediately updates the page to show the new updated values * Integrated the new EditProfile popup into UserDetails * Deleted the edit-profile.ts and the popup dialog from popups.html * Removed the event-handler from account.ts * Removed popups.scss for edit-profile #### Additional Changes Made: * Changed twitter schema maxlength to 15 instead of 20 * Using tailwind instead of popups.scss * Added EditProfile to modals.ts ### Checks - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. Closes #7683 --------- Co-authored-by: Christian Fehmer <cfe@sexy-developer.com> Co-authored-by: Christian Fehmer <fehmer@users.noreply.github.com>
… (#7970) ### Description I noticed that when trying to host Monkeytype over a local network or the internet instead of `localhost`, the frontend crashes with an `Uncaught TypeError: crypto.randomUUID is not a function` error. This happens because modern browsers restrict this API to secure contexts (HTTPS). When putting a reverse proxy in front to handle HTTPS, it's very easy to run into Mixed Content blocks or 404 errors due to incorrect `.env` configurations (like adding a trailing slash to `MONKEYTYPE_FRONTENDURL` or forgetting to completely recreate the containers). This PR updates `SELF_HOSTING.md` to: - Explain the HTTPS requirement for network deployments. - Detail how to properly configure the backend URL in the `.env` file to avoid API 404 errors (the trailing slash issue). - Highlight the importance of using `docker compose up -d --force-recreate` and clearing the browser cache, since environment variables are baked into the SPA static files at startup. ### Checks - [X] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [X] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
…@byseif21) (#6767) not a full cleanup <img width="574" height="121" alt="Screenshot 2026-03-27 144457" src="https://github.com/user-attachments/assets/eafb2065-a511-4d71-8ebb-b65b15dcd69d" /> if we decided one day to clean it all here is a reference of what needs to be [cleaned up](#6682 (comment))
…7788) Co-authored-by: Jack <jack@monkeytype.com>
**commit 1:** horizontal shift <img width="1280" height="450" alt="horizontalShift" src="https://github.com/user-attachments/assets/806c12da-7f3f-40b5-8185-346e7d785392" /> **commit 3:** vertical shift <img width="840" height="400" alt="verticalShift" src="https://github.com/user-attachments/assets/d64c5bed-c9a8-4b03-9d49-d1f1b69d3468" />
### Description At the moment, it is impossible to tell which page of [monkeytype.com/leaderboards](https://www.monkeytype.com/leaderboards) you are on just from the content of the webpage. One must look at the URL parameters (*/leaderboards?...&page=X*) in order to get this information. So, I added a numerical indicator next to the page control buttons. All this code does is add a **span** element in the same container as the page control buttons. The span is placed to the left of the buttons and is given a lot of the same Tailwind classes. The page number in the span comes from the data that is already being passed down to the buttons. **Old:** <img width="1234" height="454" alt="image" src="https://github.com/user-attachments/assets/2e530854-3490-4791-ab72-4dc2c454319c" /> **New** (replication of my approach, made with Chrome Inspector)**:** <img width="1218" height="514" alt="image" src="https://github.com/user-attachments/assets/ef58d816-ff33-48d8-a300-bdf519f4f549" /> ### Closes Discussion #7815. My first open source contribution
### Description ## Add Lao language (ພາສາລາວ) ### Changes - Added `frontend/static/languages/lao.json` with 500 common Lao words - Added `lao` to `LanguageSchema` enum in `packages/schemas/src/languages.ts` ### Language details - **Name:** Lao (ພາສາລາວ) - **BCP47 tag:** `lo` - **Script:** Lao script (Unicode block U+0E80–U+0EFF) - **Direction:** Left to right - **Ligatures:** No - **Ordered by frequency:** No ### Checks - [ ] Adding quotes? - Make sure to follow the [quotes documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/QUOTES.md) - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [x] Adding a language? - Make sure to follow the [languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md) - [x] Add language to `packages/schemas/src/languages.ts` - [x] Add language to exactly one group in `frontend/src/ts/constants/languages.ts` - [x] Add language json file to `frontend/static/languages` - [ ] Adding a theme? - Make sure to follow the [themes documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/THEMES.md) - [ ] Add theme to `packages/schemas/src/themes.ts` - [ ] Add theme to `frontend/src/ts/constants/themes.ts` - [ ] (optional) Add theme css file to `frontend/static/themes` - [ ] Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request - [ ] Adding a layout? - [ ] Make sure to follow the [layouts documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LAYOUTS.md) - [ ] Add layout to `packages/schemas/src/layouts.ts` - [ ] Add layout json file to `frontend/static/layouts` - [ ] Adding a font? - Make sure to follow the [fonts documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/FONTS.md) - [ ] Add font file to `frontend/static/webfonts` - [ ] Add font to `packages/schemas/src/fonts.ts` - [ ] Add font to `frontend/src/ts/constants/fonts.ts` - [ ] Check if any open issues are related to this PR; if so, be sure to tag them below. - [ ] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [ ] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. <!-- label(optional scope): pull request title (@your_github_username) --> <!-- I know I know they seem boring but please do them, they help us and you will find out it also helps you. --> ### Notes Lao is the official language of the Lao PDR with approximately 7 million native speakers. There is currently no Lao option in Monkeytype — this adds basic support for the community. Happy to adjust word count, fix any issues, or split into separate PRs if needed! Closes # <!-- The issue(s) your PR resolves if any (delete if that is not the case) --> <!-- Please reference any issues and/or PRs related to your pull request --> <!-- Pro tip: you can mention an issue, PR, or discussion on GitHub by referencing its hash number, e.g.: [#1234](#1234) --> <!-- Pro tip: you can press . (dot or period) in the code tab of any GitHub repo to get access to GitHub's VS Code web editor. Enjoy! :) --> --------- Co-authored-by: Jack <jack@monkeytype.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )