Skip to content

fix null field when translate to sigma #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saltar-ua merged 1 commit into from
Dec 4, 2023
Merged

fix null field when translate to sigma #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions siem-converter/app/converter/platforms/sigma/renders/sigma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,16 @@ def generate_not(self, data: Any, source_mapping: SourceMapping):
return not_node

@staticmethod
def generate_field(data: Field, source_mapping: SourceMapping):
def map_field(source_mapping: SourceMapping, generic_field_name: str) -> str:
field_name = source_mapping.fields_mapping.get_platform_field_name(generic_field_name)
return field_name or generic_field_name

def generate_field(self, data: Field, source_mapping: SourceMapping):
source_id = source_mapping.source_id
generic_field_name = data.generic_names_map[source_id]
if not generic_field_name:
raise StrictPlatformFieldException(field_name=data.source_name, platform_name="Sigma")
field_name = source_mapping.fields_mapping.get_platform_field_name(generic_field_name)
field_name = self.map_field(source_mapping, generic_field_name)
if data.operator.token_type != OperatorType.EQ:
field_name = f"{field_name}|{data.operator.token_type}"
if isinstance(data.values, list) and len(data.values) == 1 or isinstance(data.values, (str, int)):
Expand Down