#1375 Units for false_easting and false_northing (fix)#1455
Closed
adriaanse-deltares wants to merge 1 commit intoUnidata:maint-5.xfrom
Closed
Conversation
Member
|
I appreciate you taking the time to make this PR, and it certainly gave me some hints when trying to untangle what was happening. As I said over in #1375, we probably need to support the scaling in the read path. However, I was able to get the scaling addressed in the write path when writing from a Coverage, which will fix the issue of the NetCDF Subset Service producing netCDF files with mismatched cartesian coordinate units and false_easting/false_northing values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
See the description of the issue #1375
I have worked with GIS systems and Geographic projections at Deltares since 1998 and I am 100% sure that:
No exceptions exist where false easting/northing units differ from the projected coordinates. These values are intrinsic to the coordinate system's design and always share the same units
So I propose to remove the scaling of these parameters completely, also for other projections where it is applied.
PR Checklist
until ready for review