[5.x] fix s3 zarr performance issue#761
Conversation
… immediately on isValidFile in other iosps
…d from headObjectRequest
| @Category(NotPullRequest.class) | ||
| public void bucketAndKeyOsdc() throws IOException { | ||
| long lastModified = 1611593614000L; | ||
| long lastModified = 1619161328000L; |
There was a problem hiding this comment.
this tests is still going through the same codepath (i.e. getting last modified from headObjectResponse) but the lastmodified seems to have changed
There was a problem hiding this comment.
Yeah, I think we should disable the last modified portion of the tests. It seems like the last modified time changes occasionally on all platforms, but I'm not sure why...maybe shifting disks on the object store or data centers? It has happened most often on the Open Science Data Cloud.
There was a problem hiding this comment.
I can do that
lesserwhirls
left a comment
lesserwhirls
left a comment
There was a problem hiding this comment.
Assuming the JDK 8 test actually finishes, this looks great to me!
Reviewed 8 of 9 files at r1, 1 of 1 files at r2.
Dismissed @haileyajohnson from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @haileyajohnson)
cdm/s3/src/test/java/thredds/inventory/s3/TestMFileS3.java, line 111 at r1 (raw file):
Previously, haileyajohnson wrote…
I can do that
👍
|
woohoo! |
2 participants
Description of Changes
isValidFilein other iospsPR Checklist
(e.g. "[5.x]: This is my PR title")
(these labels start with "port: ")
until ready for review
This change is