[5.x]: Handle NULL string attributes in HDF5.#800
Merged
haileyajohnson merged 2 commits intoUnidata:maint-5.xfrom Aug 20, 2021
Merged
[5.x]: Handle NULL string attributes in HDF5.#800haileyajohnson merged 2 commits intoUnidata:maint-5.xfrom
haileyajohnson merged 2 commits intoUnidata:maint-5.xfrom
Conversation
…tes. Both old and new APIs
Both old and new APIs.
Contributor
|
Oh, good, this is the push I was waiting for. |
haileyajohnson
approved these changes
Aug 20, 2021
Contributor
haileyajohnson
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lesserwhirls)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Port #798 from
developto5.x, for both old and new APIs. Closes #797.PR Checklist
(e.g. "[5.x]: This is my PR title")
(these labels start with "port: ")
until ready for review
This change is