Skip to content

[5.x]: Handle NULL string attributes in HDF5.#800

Merged
haileyajohnson merged 2 commits intoUnidata:maint-5.xfrom
lesserwhirls:nilstr-5
Aug 20, 2021
Merged

[5.x]: Handle NULL string attributes in HDF5.#800
haileyajohnson merged 2 commits intoUnidata:maint-5.xfrom
lesserwhirls:nilstr-5

Conversation

@lesserwhirls
Copy link
Copy Markdown
Member

@lesserwhirls lesserwhirls commented Aug 19, 2021

Description of Changes

Port #798 from develop to 5.x, for both old and new APIs. Closes #797.

PR Checklist

  • Indicate the version associated with this PR in the Title
    (e.g. "[5.x]: This is my PR title")
  • Link to any issues that the PR addresses
  • Add labels, especially if the PR should be ported to other versions
    (these labels start with "port: ")
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

This change is Reviewable

@lesserwhirls lesserwhirls marked this pull request as ready for review August 19, 2021 22:39
@rschmunk
Copy link
Copy Markdown
Contributor

Oh, good, this is the push I was waiting for.

Copy link
Copy Markdown
Contributor

@haileyajohnson haileyajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lesserwhirls)

@haileyajohnson haileyajohnson merged commit b766604 into Unidata:maint-5.x Aug 20, 2021
@lesserwhirls lesserwhirls deleted the nilstr-5 branch August 20, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants