Skip to content

try micromamba#1187

Merged
jswhit merged 3 commits intoUnidata:masterfrom
ocefpaf:check_win_failure
Sep 1, 2022
Merged

try micromamba#1187
jswhit merged 3 commits intoUnidata:masterfrom
ocefpaf:check_win_failure

Conversation

@ocefpaf
Copy link
Copy Markdown
Collaborator

@ocefpaf ocefpaf commented Aug 31, 2022

Debugging #1186

@ocefpaf ocefpaf force-pushed the check_win_failure branch 4 times, most recently from 42b649a to 8311bb3 Compare August 31, 2022 17:44
@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 31, 2022

@hmaarrfk I believe the changes in conda-forge/zlib-feedstock#62 broke the Windows CIs here. Using the previous version or build number before that PR works. As the author of that PR do you mind taking a look here and help us figure this out?

@jswhit this PR adds a workaround for the zlib issue but we should unpin it when the problem is fixed upstream. I'll leave to you if we should merge this or not. There are other changes that are worth keeping regardless of decision on the zlib pin.

@ocefpaf ocefpaf marked this pull request as ready for review August 31, 2022 18:09
@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 31, 2022

I believe the failure there is a network issue and should pass with restart.

@ocefpaf ocefpaf force-pushed the check_win_failure branch from 8311bb3 to ea5dfbc Compare August 31, 2022 18:31
@hmaarrfk
Copy link
Copy Markdown
Contributor

@hmaarrfk
Copy link
Copy Markdown
Contributor

is the issue that libnetcdf fails, or that this build here fails?

@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 31, 2022

is the issue that libnetcdf fails, or that this build here fails?

The build here fails. The debug info is in #1186 (comment)

@jswhit
Copy link
Copy Markdown
Collaborator

jswhit commented Aug 31, 2022

thanks for fixing this so quickly @ocefpaf !

@hmaarrfk
Copy link
Copy Markdown
Contributor

do you have a build that just add zlib instead of pinning it?

Comment thread .github/workflows/miniconda.yml Outdated
Comment thread .github/workflows/miniconda.yml Outdated
ocefpaf and others added 2 commits August 31, 2022 16:55
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@hmaarrfk
Copy link
Copy Markdown
Contributor

feel free to squash.

@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 31, 2022

feel free to squash.

I'll leave that to @jswhit, not sure what he prefers. Thanks @hmaarrfk for the quick debug!

@jswhit
Copy link
Copy Markdown
Collaborator

jswhit commented Aug 31, 2022

If the fix upstream will happen soon, I'd prefer to wait for that. I'll leave this open in the meantime. Which changes in this PR do we need even after the upstream fix?

@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 31, 2022

If the fix upstream will happen soon, I'd prefer to wait for that. I'll leave this open in the meantime. Which changes in this PR do we need even after the upstream fix?

Sorry. I should've said before. @hmaarrfk figured out the real issue and it is that we were depending on an indirect pull of libzlib. B/c netcdf4-python depends on zlib directly we have to make it an explicit dependency, no need for workarounds with previous versions.

This should be good to go as-is.

@hmaarrfk
Copy link
Copy Markdown
Contributor

To be clear, the "fix" upstream is the same as the fix here. Add zlib as a conda package at build time.
conda-forge/netcdf4-feedstock#138

@jswhit jswhit merged commit 9ddebc9 into Unidata:master Sep 1, 2022
@ocefpaf ocefpaf deleted the check_win_failure branch September 1, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants