Skip to content

Conversation

@eea03
Copy link

@eea03 eea03 commented Nov 9, 2015

Copy of #547

Resolves #546
partly resolves #544

eea03 added 2 commits November 5, 2015 17:00
… to improve performance. Until now, unreasonable count of selects were pointlessly generated every time table was refreshed, even though data were not changed and there was no point to reload them
…al selects to retrieve Schedules. Fixed bug with refresher (table wasn't refreshing after schedule detail window opened and closed)
@skodapetr
Copy link
Member

Just a note to consider ..
Some of those views utilize DbCachedSource

https://github.com/UnifiedViews/Core/blob/feature/pipelineAndExecutionViewsPerformance/frontend/src/main/java/cz/cuni/mff/xrg/odcs/frontend/doa/container/db/DbCachedSource.java

This class in fact already "do" some caching. It may be reasonable to do the changes there rather than add another caching layer for each component separately.

@skrchnavy skrchnavy assigned eea03 and unassigned skrchnavy Nov 9, 2015
@eea03
Copy link
Author

eea03 commented Nov 9, 2015

Yes I am aware of the existing cache mechanism. However these caches back up the table data itself and they use the database views and corresponding Java objects (PipelineView / ExecutionView).
The methods for evaluating permissions and others causing so much selects require single Pipeline / Execution objects.
In order to reuse the existing caches we would have to reimplement quite a big amount of code.

I am aware that this is not an optimal solution to have 2 caches but at least in eDemo we need a quick fix of these performance issues so we implemented it this way

eea03 added a commit that referenced this pull request Nov 12, 2015
…nViewsPerformance

Pipeline, execution and schedule views performance issues fix to 2.2.x develop
@eea03 eea03 merged commit 4bff890 into version_2.2.X/develop Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants