Merged in the latest changes to the "javadoc" command from OakBot. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I would personally put these two on separate lines...
There was a problem hiding this comment.
also full would rather be named qualified ;)
There was a problem hiding this comment.
Or maybe fullyQualified
|
about now I am half through.... I will do a thorough check on the rest tomorrow ;) |
There was a problem hiding this comment.
this whole if-else construct wants to be hidden inside a method
|
What's overall left to say is that |
Merged
Vogel612
added a commit
that referenced
this pull request
Jan 25, 2015
Merged in the latest changes to the "javadoc" command from OakBot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.