Optimize performance and write performance tests for various FSDA toolbox functions#127
Conversation
performance tests using matlab-write-performance-tests skills from the MATLAB Agentic Toolkit.
|
fsda_test_errors.csv Thank you for your work on this performance optimization and the new I have tested your changes using a local test script that covers all function alongside your new performance tests. The performance suite runs correctly, but I have a couple of points to address:
|
| @@ -1,68 +1,23 @@ | |||
| function d = mahalFS(Y,MU,SIGMA) | |||
| %mahalFS computes Mahalanobis distances (in squared units) for each row of matrix Y | |||
| %mahalFS computes Mahalanobis distances (in squared units) for each row of matrix Y | |||
| end | ||
|
|
||
| %} | ||
| % Optimized: delegates to compiled MEX (9x faster) when available, |
| mdr = FSRmdr(y,X,out.bs,'init',init); | ||
| mdrStore(:,j)=mdr(:,2); | ||
| end | ||
| % MDRenv: forward envelopes of mdr. Matrix. |
| % | ||
| % In the IRWLS procedure the value of loc and the value of the scale and | ||
| % of the shape matrix are updated in each step | ||
| %IRWLSmult Optimized IRWLS with inlined Tukey biweight and Cholesky mahalFS. |
| % | ||
| % init : Point where to start monitoring. Scalar. | ||
| % prob: quantiles for which envelopes have to be computed. Vector. | ||
| % scaled: If true, no consistency factor applied. Boolean. |
There was a problem hiding this comment.
@sindhujapr thanks again for your PR and thanks again to MathWorks for the help. Please, give us some time to review your code and for the moment please ignore all the other suggestions.
|
@sindhujapr on behalf of all the FSDA group we wish to thank you very much. We have revised the modifications and and we are going to add additional comments inside the modified files so that the user can immediately see the modifications without the need of comparing the files to previous versions. |
|
Thanks for incorporating these changes. Please let me know if any follow up is required. |
3 participants
Proposed changes
The changes include suggested optimizations (using the matlab-optimize-performance skill) and performance tests (using the matlab-write-performance-tests skill) for various functions of the FSDA toolbox. These skills are available in the MATLAB Agentic Toolkit: https://github.com/matlab/matlab-agentic-toolkit.
Note: The matlab-optimize-performance skill tested for correctness of the functions it optimized as part of iterative optimization methodology.
Issue: #126
Types of changes
What types of changes does your code introduce to FSDA?
Put an
xin the boxes that apply